-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubeadm configfile beta - add documentation for images #2513
Kubeadm configfile beta - add documentation for images #2513
Conversation
Perhaps |
participant "node\n(api object)" as n | ||
|
||
u->k: UpgradeConfiguration | ||
note over u, n:Upgrade configuration should allow only well-know changes to the cluster e.g. change of custom images if used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well-know
-> well known
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. change
-> , e.g. the change
kpcm->k: | ||
k->k:update KubeProxy\ncomponent config\nusing api machinery | ||
k->kpcm:save updated KubeProxy component config | ||
note over kpcm, n:the updaed KubeProxy component config will\nbe used by the updated kube-proxy DaemonsSet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DaemonsSet
-> DaemonSet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updaed
-> updated
participant "kubeproxy-config\nConfigMap" as kpcm | ||
participant "kubelet-config\nConfigMap-1.*" as kcm | ||
|
||
u->k:provide\nInitConfiguration (with NodeRegistrationOptions, Master)\nClusterConfiguration\nKubeProxy component config\nKubelet component config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubelet
-> kubelet
(case-sensitive search-and-replace would solve as there are more than one instances.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
component config
-> component configuration
?
(present in other places too)
|
||
k->cm:read ClusterConfiguration | ||
cm->k: | ||
k->cm:remove Master\nfrom ClusterConfiguration.Status\n(only if the node is master) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is master
-> is a Control Plane node
k->kk:write NodeRegistrationOptions\nto /var/lib/kubelet/kubeadm-flags.env | ||
kk->n:start node | ||
|
||
note over kcm, n:the updated Kubelet component config\nwill be used by other nodes\nby running\nkubeadm upgrade nodes locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\nby running
-> \nwhen running
## kubeadm upgrade node | ||
|
||
``` | ||
title kubeadm upgrade node (interactions with v1beta1 config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1beta1 config
-> the v1beta1 configuration
## kubeadm upgrade | ||
|
||
``` | ||
title kubeadm upgrade apply (interactions with v1beta1 config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1beta1
-> the v1beta1 configuration
## kubeadm reset | ||
|
||
``` | ||
title kubeadm reset (interactions with v1beta1 config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1beta1 config
-> the v1beta1 configuration
thanks for the writeup @fabriziopandini 👍 |
d81f869
to
c975a70
Compare
@neolit123 @rosti Many thanks for the feedbacks! |
Thanks for this documentation @fabriziopandini! Super helpful to make this be more editable by other people. |
/assign @timothysc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in and if needed refine more in 1.13
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…gfile-beta-documentation Kubeadm configfile beta - add documentation for images
As requested in this comment, this PR adds documentation about how to update / edit images linked from KEP0023 - Kubeadm configfile beta
/CC @timothysc @liztio